-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release proposal: v3.0.0 #2299
Release proposal: v3.0.0 #2299
Conversation
Updated known issues to include:
|
From v3.0.0-alpha, essentially identical to this branch: From this branch: Moving forward with release if that comes out green sans known flaky tests |
I have this for
But it feels a bit too hand-wavy. @trevnorris' current measurements suggests there may be up to a 70% degradation in If anyone has suggestions for how to convey useful information without making it sound too scary or providing negative-tweet-fodder then I'd love to hear it! |
Sorry, "70% degradation" is wrong, more meaningful to say that instantiation is now taking between 150% and 170% in v3 over what it takes with v2. |
IMO the current text seems good. Instantiation takes longer (usually? sometimes? always?), but access and use is faster for certain sizes IIUC. "Different performance profile" sounds about right. @trevnorris seems like the one you really want to answer though. |
@domenic re Buffer performance difference. I remember it being comparable in v4.3, and even faster as buffers grew larger (less impact on GC), but in v4.4 the performance has drastically decreased. You can even see that using any normal typed array. Not just in Buffer. |
|
|
945e34e
to
f066fe3
Compare
It would be great to see how it performs in io.js's own benchmarks suite, compared to 2.5.0 |
Error in docs for repl stuff, I'll fix in a PR
|
Can I get an LGTM for this commit changing the heading levels for the new REPL docs? rvagg@02a2e5e @Fishrock123 if you're around it'd be good to have you comment too |
docs commit LGTM. |
Docs fixes LGTM |
PR-URL: nodejs#2299 Reviewed-by: Stephen Belanger <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Notable changes: * buffer: - Due to changes in V8, it has been necessary to reimplement Buffer on top of V8's Uint8Array. While every effort has been made to maintain performance, users are likely to experience a different performance profile depending on how Buffer is used. (Trevor Norris) nodejs#1825. - Buffer can now take ArrayBuffers as a constructor argument (Trevor Norris) nodejs#2002. - When a single buffer is passed to Buffer.concat(), a new, copied Buffer object will be returned; previous behavior was to return the original Buffer object (Sakthipriyan Vairamani) nodejs#1937. * build: PPC support has been added to core to allow compiling on pLinux BE and LE (AIX support coming soon) (Michael Dawson) nodejs#2124. * dgram: If an error occurs within socket.send() and a callback has been provided, the error is only passed as the first argument to the callback and not emitted on the socket object; previous behavior was to do both (Matteo Collina & Chris Dickinson) nodejs#1796 * freelist: Deprecate the undocumented freelist core module (Sakthipriyan Vairamani) nodejs#2176. * http: - Status codes now all use the official IANA names as per RFC7231, e.g. http.STATUS_CODES[414] now returns 'URI Too Long' rather than 'Request-URI Too Large' (jomo) nodejs#1470. - Calling .getName() on an HTTP agent no longer returns a trailing colon, HTTPS agents will no longer return an extra colon near the middle of the string (Brendan Ashworth) nodejs#1617. * node: - NODE_MODULE_VERSION has been bumped to 45 to reflect the break in ABI (Rod Vagg) nodejs#2096. - Introduce a new process.release object that contains a name property set to 'io.js' and sourceUrl, headersUrl and libUrl (Windows only) properties containing URLs for the relevant resources; this is intended to be used by node-gyp (Rod Vagg) nodejs#2154. - The version of node-gyp bundled with io.js now downloads and uses a tarball of header files from iojs.org rather than the full source for compiling native add-ons; it is hoped this is a temporary floating patch and the change will be upstreamed to node-gyp soon (Rod Vagg) nodejs#2066. * repl: Persistent history is now enabled by default. The history file is located at ~/.node_repl_history, which can be overridden by the new environment variable NODE_REPL_HISTORY. This deprecates the previous NODE_REPL_HISTORY_FILE variable. Additionally, the format of the file has been changed to plain text to better handle file corruption. (Jeremiah Senkpiel) nodejs#2224. * smalloc: The smalloc module has been removed as it is no longer possible to provide the API due to changes in V8 (Ben Noordhuis) nodejs#2022. * tls: Add server.getTicketKeys() and server.setTicketKeys() methods for TLS session key rotation (Fedor Indutny) nodejs#2227. * v8: Upgraded to 4.4.63.26 - ES6: Enabled computed property names - ES6: Array can now be subclassed in strict mode - ES6: Implement rest parameters in staging, use the --harmony-rest-parameters command line flag - ES6: Implement the spread operator in staging, use the --harmony-spreadcalls command line flag - Removed SetIndexedPropertiesToExternalArrayData and related APIs, forcing a shift to Buffer to be reimplemented based on Uint8Array - Introduction of Maybe and MaybeLocal C++ API for objects which may or may not have a value. - Added support for PPC PR-URL: nodejs#2299
thanks both, new build @ https://jenkins-iojs.nodesource.com/job/iojs+release/69/ |
Heading looks fine. LGTM |
Taking over from #2221, the commits there are now in master, the remaining commit is the release commit which is in this PR.
CHANGELOG entry copied here:
2015-08-04, Version 3.0.0, @rvagg
Notable changes
Buffer
on top of V8'sUint8Array
. While every effort has been made to maintain performance, users are likely to experience a different performance profile depending on howBuffer
is used. (Trevor Norris) #1825.Buffer
can now takeArrayBuffer
s as a constructor argument (Trevor Norris) #2002.Buffer.concat()
, a new, copiedBuffer
object will be returned; previous behavior was to return the originalBuffer
object (Sakthipriyan Vairamani) #1937.socket.send()
and a callback has been provided, the error is only passed as the first argument to the callback and not emitted on thesocket
object; previous behavior was to do both (Matteo Collina & Chris Dickinson) #1796freelist
core module (Sakthipriyan Vairamani) #2176.http.STATUS_CODES[414]
now returns'URI Too Long'
rather than'Request-URI Too Large'
(jomo) #1470.NODE_MODULE_VERSION
has been bumped to45
to reflect the break in ABI (Rod Vagg) #2096.process.release
object that contains aname
property set to'io.js'
andsourceUrl
,headersUrl
andlibUrl
(Windows only) properties containing URLs for the relevant resources; this is intended to be used by node-gyp (Rod Vagg) #2154.NODE_REPL_HISTORY
. This deprecates the previousNODE_REPL_HISTORY_FILE
variable. Additionally, the format of the file has been changed to plain text to better handle file corruption. (Jeremiah Senkpiel) #2224.smalloc
module has been removed as it is no longer possible to provide the API due to changes in V8 (Ben Noordhuis) #2022.server.getTicketKeys()
andserver.setTicketKeys()
methods for TLS session key rotation (Fedor Indutny) #2227.Array
can now be subclassed in strict mode--harmony-rest-parameters
command line flag--harmony-spreadcalls
command line flagSetIndexedPropertiesToExternalArrayData
and related APIs, forcing a shift toBuffer
to be reimplemented based onUint8Array
Maybe
andMaybeLocal
C++ API for objects which may or may not have a value.Known issues
See https://github.com/nodejs/io.js/labels/confirmed-bug for complete and current list of known issues.
beforeExit
are still to be resolved. See #1264.process.send()
is not synchronous as the docs suggest, a regression introduced in 1.0.2, see #760.dns.setServers()
while a DNS query is in progress can cause the process to crash on a failed assertion. #894url.resolve
may transfer the auth portion of the url when resolving between two full hosts, see #1435.Commits
60a974d200
] - buffer: fix missing null/undefined check (Trevor Norris) #2195e6ab2d92bc
] - buffer: fix not return on error (Trevor Norris) #22251057d1186b
] - buffer: rename internal/buffer_new.js to buffer.js (Ben Noordhuis) #20224643b8b667
] - (SEMVER-MINOR) buffer: allow ArrayBuffer as Buffer argument (Trevor Norris) #2002e5ada116cd
] - buffer: minor cleanup from rebase (Trevor Norris) #2003b625ab4242
] - buffer: fix usage of kMaxLength (Trevor Norris) #2003eea66e2a7b
] - (SEMVER-MAJOR) buffer: fix case of one buffer passed to concat (Sakthipriyan Vairamani) #19378664084166
] - buffer: make additional changes to native API (Trevor Norris) #182536f78f4c1c
] - buffer: switch API to return MaybeLocal (Trevor Norris) #1825571ec13841
] - buffer: switch to using Maybe API (Trevor Norris) #1825d75f5c8d0e
] - buffer: finish implementing FreeCallback (Trevor Norris) #182563da0dfd3a
] - buffer: implement Uint8Array backed Buffer (Trevor Norris) #182523be6ca189
] - buffer: allow ARGS_THIS to accept a name (Trevor Norris) #1825971de5e417
] - build: prepare Windows installer for i18n support (Frederic Hemberger) #22472ba8b23661
] - build: add 'x86' option back in to configure (Rod Vagg) #2233b4226e797a
] - build: first set of updates to enable PPC support (Michael Dawson) #212424dd016deb
] - build: produce symbol map files on windows (Ali Ijaz Sheikh) #2243423d8944ce
] - cluster: do not unconditionally set --debug-port (cjihrig) #1949fa98b97171
] - cluster: add handle ref/unref stubs in rr mode (Ben Noordhuis) #2274944f68046c
] - crypto: remove kMaxLength on randomBytes() (Trevor Norris) #18253d3c687012
] - deps: update V8 to 4.4.63.26 (Michaël Zasso) #22203aad4fa89a
] - deps: upgrade v8 to 4.4.63.12 (Ben Noordhuis) #209270d1f32f56
] - (SEMVER-MAJOR) deps: update v8 to 4.4.63.9 (Ben Noordhuis) #2022deb7ee93a7
] - deps: backport 7b24219346 from v8 upstream (Rod Vagg) #1805d58e780504
] - (SEMVER-MAJOR) deps: update v8 to 4.3.61.21 (Chris Dickinson) iojs/io.js#16322a63cf612b
] - deps: make node-gyp work with io.js (cjihrig) iojs/io.js#990bf63266460
] - deps: upgrade to npm 2.13.3 (Kat Marchán) #2284ef2c8cd4ec
] - (SEMVER-MAJOR) dgram: make send cb act as "error" event handler (Matteo Collina) #17963da057fef6
] - (SEMVER-MAJOR) dgram: make send cb act as "error" event handler (Chris Dickinson) #1796df1994fe53
] - _Revert_ "dns: remove AI_V4MAPPED hint flag on FreeBSD" (cjihrig) iojs/io.js#15551721968b22
] - doc: document repl persistent history changes (Jeremiah Senkpiel) #2224d12df7f159
] - doc: update v8 flags in man page (Michaël Zasso) iojs/io.js#1701d168d01b04
] - doc: properly inheriting from EventEmitter (Sakthipriyan Vairamani) #2168500f2538cc
] - doc: a listener, not "an" listener (Sam Roberts) #102554627a919d
] - doc: server close event does not have an argument (Sam Roberts) #1025ed85c95a9c
] - doc,test: documents behaviour of non-existent file (Sakthipriyan Vairamani) #21692965442308
] - (SEMVER-MAJOR) http: fix agent.getName() and add tests (Brendan Ashworth) #16172d9456e3e6
] - (SEMVER-MAJOR) http: use official IANA Status Codes (jomo) #147011e4249227
] - (SEMVER-MAJOR) http_server:prefinish
vsfinish
(Fedor Indutny) #14119bc2e26720
] - net: do not set V4MAPPED on FreeBSD (Julien Gilli) iojs/io.js#1555ba9ccf227e
] - node: remove redundant --use-old-buffer (Rod Vagg) #2275ef65321083
] - (SEMVER-MAJOR) node: do not overridemessage
/stack
of error (Fedor Indutny) #21089f727f5e03
] - node-gyp: detect RC build with x.y.z-rc.n format (Rod Vagg) #2171e52f963632
] - node-gyp: download header tarball for compile (Rod Vagg) #2066902c9ca51d
] - node-gyp: make aware of nightly, next-nightly & rc (Rod Vagg) #20664cffaa3f55
] - (SEMVER-MINOR) readline: allow tabs in input (Rich Trott) #1761ed6c249104
] - (SEMVER-MAJOR) repl: persist history in plain text (Jeremiah Senkpiel) #2224f7d5e4c618
] - (SEMVER-MINOR) repl: default persistence to ~/.node_repl_history (Jeremiah Senkpiel) #2224ea05e760cd
] - repl: don't clobber RegExp.$ properties (Sakthipriyan Vairamani) #2137d20093246b
] - src: disable vector ICs on arm (Michaël Zasso) #222004fd4fad46
] - (SEMVER-MINOR) src: introduce process.release object (Rod Vagg) #21549d34bd1147
] - src: increment NODE_MODULE_VERSION to 45 (Rod Vagg) #2096ceee8d2807
] - test: add tests for persistent repl history (Jeremiah Senkpiel) #22248e1a8ffe24
] - test: remove two obsolete pummel tests (Ben Noordhuis) #2022ae731ec0fa
] - test: don't use arguments.callee (Ben Noordhuis) #202221d31c08e7
] - test: remove obsolete harmony flags (Chris Dickinson)64cf71195c
] - test: change the hostname to an invalid name (Sakthipriyan Vairamani) #228780a1cf7425
] - test: fix messages and use return to skip tests (Sakthipriyan Vairamani) #2290d5ab92bcc1
] - test: use common.isWindows consistently (Sakthipriyan Vairamani) #2269bc733f7065
] - test: fix fs.readFile('/dev/stdin') tests (Ben Noordhuis) #22653cbb5870e5
] - tools: expose skip output to test runner (Johan Bergström) #21303b021efe11
] - vm: fix symbol access (Domenic Denicola) #17737b81e4ba36
] - vm: remove unnecessary access checks (Domenic Denicola) #1773659dadd410
] - vm: fix property descriptors of sandbox properties (Domenic Denicola) #17739bac1dbae9
] - win,node-gyp: enable delay-load hook by default (Bert Belder) iojs/io.js#1433